[IDE Service] Move warmup logic to JetBrains Launcher #15233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Dec 8, 2022
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
from
845abc2 to
275d1f1
Compare
andreafalzetti
changed the title
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
andreafalzetti
added
team: IDE
do-not-merge/release-note-label-needed
editor: jetbrains
and removed
release-note-none
labels
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
This comment was marked as resolved.
This comment was marked as resolved.
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
from
275d1f1 to
18201ea
Compare
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
2 times, most recently
from
b4603f9 to
7836901
Compare
This comment was marked as resolved.
This comment was marked as resolved.
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
4 times, most recently
from
377ca81 to
4b522a1
Compare
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
from
49289d1 to
399d72b
Compare
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
from
349565e to
5a1717f
Compare
akosyakov
reviewed
Dec 13, 2022
akosyakov
reviewed
Dec 13, 2022
akosyakov
reviewed
Dec 13, 2022
akosyakov
reviewed
Dec 13, 2022
akosyakov
reviewed
Dec 13, 2022
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
2 times, most recently
from
146d907 to
133c366
Compare
akosyakov
reviewed
Dec 13, 2022
akosyakov
reviewed
Dec 13, 2022
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
3 times, most recently
from
89895af to
fa81cea
Compare
Co-authored-by: Anton Kosyakov <[email protected]> Co-authored-by: Victor Nogueira <[email protected]>
andreafalzetti
force-pushed
the
ide/jb-warmup-logic
branch
from
fa81cea to
2987dcb
Compare
felladrin
approved these changes
Dec 14, 2022
This comment was marked as resolved.
This comment was marked as resolved.
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR to #15178 to move warmup logic from ide-service to jetbrains-launcher
It cannot be merged unless we rebuild JetBrains IDE images (both stable and latest) with this change: #15178
Co-Authored with @felladrin and @akosyakov
Related Issue(s)
Related to #6740
How to test
Manually tested obsering the logs produced by different prebuilds. Example: https://ide-jb-warmup-logic.preview.gitpod-dev.com/t/testers/spring-petclinic/40394142-6f9d-4690-a2d4-f2e5e0dd0be9
We could observe that first maven cmds are executed, and only after the warmup starts.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh